foad accepted this revision. foad added a comment. This revision is now accepted and ready to land. LGTM (though I don't really know anything about vscale!). CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109883/new/ https://reviews.llvm.org/D109883