[PATCH] D109813: [flang] GET_COMMAND_ARGUMENT(VALUE) runtime implementation

Mon Sep 20 02:15:36 PDT 2021

rovka marked an inline comment as done and an inline comment as not done.
rovka added inline comments.

================
Comment at: flang/runtime/command.cpp:15
 namespace Fortran::runtime {
 using CountType = CppTypeFor<TypeCategory::Integer, 4>;
 using LengthType = CppTypeFor<TypeCategory::Integer, 8>;
----------------
klausler wrote:
> If these types are used in the specifications of implementations of APIs then they should not be introduced here.  Implementations of functions should match their prototypes in headers, apart from maybe adding names for arguments and removing any default values.
Yeah, I introduced these as shorthand initially, but I guess it makes sense to have them in the header.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D109813/new/

https://reviews.llvm.org/D109813