[PATCH] D109661: [FunctionPropertiesAnalysis] Add `PreciseFunctionPropertiesAnalysis`

Hideto Ueno via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Sep 19 12:20:44 PDT 2021


uenoku added a comment.

> We could always make it an argument for the pass, e.g., when you create it you select the precision. Or, a command line option to get higher/lower precision. I think by default it should track all features and we can have subsets defined in a command line option if necessary. So if a user wants only 10 of the 40 features they add a selector into a command line enum and use it to skip features.

On the second thought, I think it is better to separate the pass. 
Currently, FunctionPropertiesInfo is specialized for MLInliner and intended to be used practically.
We might want  DetailedFunctionPropertiesInfo to be very rich analayzer which do not much care about the runtime cost. 
Users can use the features of DetailedFunctionPropertiesInfo in experimentally until they find the essential features for their applications.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D109661/new/

https://reviews.llvm.org/D109661



More information about the llvm-commits mailing list