[PATCH] D109807: [InstCombine] Narrow type of logical operation chains when possible

Roman Lebedev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Sep 19 08:08:16 PDT 2021


lebedev.ri added inline comments.


================
Comment at: llvm/lib/Transforms/InstCombine/InstCombineAndOrXor.cpp:1638
+                     m_Value(Z)))) &&
+      cast<BinaryOperator>(Op1)->getOpcode() == LogicOpc && I.hasOneUse()) {
+    Value *NewOp = Builder.CreateBinOp(LogicOpc, Op0, Y);
----------------
Wait, why are you checking that `I`, the root instruction, is a single-use?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D109807/new/

https://reviews.llvm.org/D109807



More information about the llvm-commits mailing list