[PATCH] D109993: [X86] Rename the X86WinAllocaExpander pass and related symbols to "DynAlloca". NFC

Simon Pilgrim via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Sep 18 12:19:22 PDT 2021


RKSimon added a comment.

This probably needs a mention in the release notes

Is there any way that we can ensure we have preparatory test coverage for this with a darwin triple or is that premature?



================
Comment at: llvm/lib/Target/X86/X86DynAllocaExpander.cpp:198
 
-void X86WinAllocaExpander::lower(MachineInstr* MI, Lowering L) {
+void X86DynAllocaExpander::lower(MachineInstr* MI, Lowering L) {
   const DebugLoc &DL = MI->getDebugLoc();
----------------
Fix this?


================
Comment at: llvm/utils/gn/secondary/llvm/lib/Target/X86/BUILD.gn:136
     "X86VZeroUpper.cpp",
-    "X86WinAllocaExpander.cpp",
+    "X86DynAllocaExpander.cpp",
     "X86WinEHState.cpp",
----------------
sorting


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D109993/new/

https://reviews.llvm.org/D109993



More information about the llvm-commits mailing list