[PATCH] D108469: Improve handling of static assert messages.

[Corentin Jabot via Phabricator via llvm-commits]

cor3ntin added a comment.

In D108469#3002209 <https://reviews.llvm.org/D108469#3002209>, @aaron.ballman wrote:

> In D108469#2957652 <https://reviews.llvm.org/D108469#2957652>, @jfb wrote:
>
>> I worry that changing the general `static_assert` printing (adding a colon, and dropping the quotes) will get @hwright's law to drop on us. We can try and see if e.g. users of clang have automated checks for `static_assert` in their CI pipelines or something. I think your new format looks better, but Hyrum is finicky that way... What do others think?
>
> I think it's fine to change; we've never promised diagnostic formatting compatibility between versions. I'm sure *someone* is relying on this somewhere, but I'm not worried we're going to break a ton of people -- hopefully enough folks are tracking trunk that we can find any major issues before releasing.
>
> Btw, it looks like the CI is currently failing the LLVM unit tests in interesting ways. That should be resolved.
>
> There are changes in `clang/test/Lexer/null-character-in-literal.c` but Phab is unhelpful about showing what those changes are because it thinks the file is a binary file. Can you explain what's been changed there?

A verbatim NULL is replaced by <U+0000> in the expected-error of a test that checks the handling of null in header-name (!)

  -                          // expected-error at -1 {{'null\^@character' file not found}}
  +                          // expected-error at -1 {{'null\<U+0000>character' file not found}}




Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D108469/new/

https://reviews.llvm.org/D108469