[PATCH] D109989: [X86] Improve i8 all-ones element insertion in pre-SSE4.1

[Roman Lebedev via Phabricator via llvm-commits]

lebedev.ri added a comment.

In D109989#3007681 <https://reviews.llvm.org/D109989#3007681>, @craig.topper wrote:

> LGTM unless we're considered about the failure to merge constant pools? I suppose the easiest fix for that would be to move this to a DAG combine between LegalizeVectorOps and LegalizeDAG?

Thank you! I think this is already better than it was before, not sure we have to fix this all the way on a single go :)
@RKSimon ?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D109989/new/

https://reviews.llvm.org/D109989