[PATCH] D109953: [X86][FP16] Combine the FADD(A, FMA(B, C, 0)) to FMA(B, C, A)

Pengfei Wang via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Sep 17 23:43:26 PDT 2021


pengfei added a comment.

In D109953#3007745 <https://reviews.llvm.org/D109953#3007745>, @craig.topper wrote:

> I'm not sure this transform is valid without no signed zeros. fma(x, y, -0.0) is equivalent to fmul.

I agree, we may need to check -0.0 and 0.0 only when 'hasNoSignedZeros' is true?

We need to mention complex FMA in the title.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D109953/new/

https://reviews.llvm.org/D109953



More information about the llvm-commits mailing list