[PATCH] D109945: [lld-macho] Simplify the handling of "no unwind info" functions

Jez Ng via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Sep 17 16:21:06 PDT 2021


int3 added inline comments.


================
Comment at: lld/MachO/UnwindInfoSection.cpp:272
+    // Write the functionAddress.
+    writeAddress(buf, d->getVA(), sizeof(Ptr) == 8 ? 3 : 2);
+    if (!d->compactUnwind)
----------------
oontvoo wrote:
> this never changes - would be nice to have it fixed somewhere rather than having to re-type it in a few places
If we end up using it in multiple places, sure


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D109945/new/

https://reviews.llvm.org/D109945



More information about the llvm-commits mailing list