[PATCH] D110000: AMDGPU: Use attributor to propagate amdgpu-flat-work-group-size

Johannes Doerfert via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Sep 17 13:56:15 PDT 2021


jdoerfert accepted this revision.
jdoerfert added a comment.
This revision is now accepted and ready to land.

Only one minor oversight, otherwise LGTM.



================
Comment at: llvm/lib/Target/AMDGPU/AMDGPUAttributor.cpp:523
+    if (!A.checkForAllCallSites(CheckCallSite, *this, true, AllCallSitesKnown))
+      indicatePessimisticFixpoint();
+
----------------



================
Comment at: llvm/test/CodeGen/AMDGPU/propagate-flat-work-group-size.ll:151
+  ret void
+}
+
----------------
Be careful with such tests. If you don't explicitly disable liveness (as you do now) this will all be deleted.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D110000/new/

https://reviews.llvm.org/D110000



More information about the llvm-commits mailing list