[PATCH] D109945: [lld-macho] Simplify the handling of "no unwind info" functions

[Vy Nguyen via Phabricator via llvm-commits]

oontvoo added inline comments.


================
Comment at: lld/MachO/UnwindInfoSection.cpp:146
 void UnwindInfoSection::prepareRelocations() {
-  for (ConcatInputSection *isec : compactUnwindSection->inputs)
-    prepareRelocations(isec);
+  // This iteration needs to be deterministic -- hence the use of a MapVector
+  // for UnwindInfoSection::symbols.
----------------
Please include the explanation on why we're doing this (for eg., "because we'll use it with parallelForEachN" )

(or perhaps move this comment to the `symbols`'s decl statement.)


================
Comment at: lld/MachO/UnwindInfoSection.cpp:272
+    // Write the functionAddress.
+    writeAddress(buf, d->getVA(), sizeof(Ptr) == 8 ? 3 : 2);
+    if (!d->compactUnwind)
----------------
this never changes - would be nice to have it fixed somewhere rather than having to re-type it in a few places


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D109945/new/

https://reviews.llvm.org/D109945