[PATCH] D106720: [Attributor] AAFunctionReachability, Instruction reachability.

[Johannes Doerfert via Phabricator via llvm-commits]

jdoerfert accepted this revision.
jdoerfert added a comment.
This revision is now accepted and ready to land.

Two comments below, otherwise LG.

As we add users we will need to extend/adjust some thing but conceptually this should be OK.



================
Comment at: llvm/lib/Transforms/IPO/AttributorAttributes.cpp:9617
 
-    /// Set of functions that are unreachable, but might become reachable.
-    DenseSet<Function *> Unreachable;
+      CallBase &CB = static_cast<CallBase &>(Inst);
+      const AACallEdges &AAEdges = A.getAAFor<AACallEdges>(
----------------
Replace static cast with `cast<CallBase>` and it is not `Inst` but `CBInst` you want to cast here.


================
Comment at: llvm/lib/Transforms/IPO/AttributorAttributes.cpp:9808
+
+  DenseMap<Instruction *, QueryResolver> InstQueries;
+
----------------
Documentation.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D106720/new/

https://reviews.llvm.org/D106720