[PATCH] D109987: [NVVM] Update intrinsic definitions to include more attributes

Johannes Doerfert via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Sep 17 11:29:17 PDT 2021


jdoerfert added inline comments.


================
Comment at: llvm/include/llvm/IR/IntrinsicsNVVM.td:657
-      Intrinsic<[llvm_float_ty], [llvm_float_ty, llvm_float_ty],
+      DefaultAttrsIntrinsic<[llvm_float_ty], [llvm_float_ty, llvm_float_ty],
         [IntrNoMem, Commutative]>;
   def int_nvvm_div_approx_f : GCCBuiltin<"__nvvm_div_approx_f">,
----------------
These commutative annotations seem wrong to me. Same for `fma`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D109987/new/

https://reviews.llvm.org/D109987



More information about the llvm-commits mailing list