[PATCH] D109597: [DebugInfo] Fix of crash due to DwarfUnit::getOrCreateContextDIE returning NULL

[David Blaikie via Phabricator via llvm-commits]

dblaikie added inline comments.


================
Comment at: llvm/test/DebugInfo/X86/dwarfdump-ContextDICompileUnit.ll:3
+
+; RUN: llc %s -filetype=obj -o - | llvm-dwarfdump - | FileCheck %s
+
----------------
dblaikie wrote:
> dblaikie wrote:
> > The title of this file seems misleading - if the bug/crash/issue is not in dwarfdump, we wouldn't usually put the word 'dwarfdump' in the test file name (like we don't put opt/llc in the name of tests that use those tools to test some transformation/lowering pass)
> Could you include something like the original C or C++ source code (or otherwise) that was used to generate this IR? (if this IR was generated from some flang input - including the instructions of how to recompile/regenerate the IR may be useful for legibility (reading the metadata is a bit painful sometimes, so including some high level description of what's going on can be useful))
> 
> It'd be interesting to know/have more details (in this test file, in the patch description, etc) about how the problematic situation arose, and why it hadn't come up until flang/what did flang do differently that triggered this?
I'm still curious to know more about what was interesting about this debug info IR that's novel in Fortran's use case/doesn't come up in Clang's use case? Can you include more detail in the patch description about what's novel/different in this debug info IR compared to the sort of thing clang typically produces, and why fortran produces it?

(this test case got updated and lost most of the CHECK lines - I'm not sure that's the best direction either - presumably there's some behavior "behind" the crash that's worth testing that was missing/why the crash wasn't found previously. We don't just want llvm to do anything other than crash - we want some particular behavior and should check for that)


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D109597/new/

https://reviews.llvm.org/D109597