[PATCH] D91944: OpenMP 5.0 metadirective
Alexey Bataev via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Sep 17 10:41:31 PDT 2021
ABataev added inline comments.
================
Comment at: clang/include/clang/AST/StmtOpenMP.h:5412
+
+ void setIfStmt(Stmt *stmt) { IfStmt = stmt; }
+ Stmt *getIfStmt() const { return IfStmt; }
----------------
1. Make it private, please
2. Var names must start from capital letter `stmt`->`S`
================
Comment at: clang/lib/Parse/ParseOpenMP.cpp:2389
+
+ int idx = 0;
+ // In OpenMP 5.0 metadirective is either replaced by another directive or
----------------
Please, fix var names.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D91944/new/
https://reviews.llvm.org/D91944
More information about the llvm-commits
mailing list