[PATCH] D108115: [llvm][sve] Lowering for VLS masked truncating stores

David Truby via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Sep 17 09:55:13 PDT 2021


DavidTruby added a comment.

In D108115#3001669 <https://reviews.llvm.org/D108115#3001669>, @dmgreen wrote:

> Thanks for fixing the MVE issues. Most of the changes here don't look SVE related, being generic DAG combines. It would probably be best to split them into a separate review to keep logically separable additions in different reviews in case there are issues with them.

I'm nervous about splitting the DAG combine into a separate patch because it's currently only triggered by SVE code generation; adding it in a separate patch leaves it unused and untested in that patch which I'd rather try and avoid.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D108115/new/

https://reviews.llvm.org/D108115



More information about the llvm-commits mailing list