[PATCH] D109976: [CSSPGO] Tweakes to lower pseudo probe runtime overhead

[Wenlei He via Phabricator via llvm-commits]

wenlei accepted this revision.
wenlei added a comment.
This revision is now accepted and ready to land.

ltgm, thanks for the fix.

> Allow general default attributes (nofree nosync nounwind) for pseudo probe intrinsic.

Can you expand in this commit message to also explain what problem this caused and fixed -- containing function cannot have these attribute.



================
Comment at: llvm/lib/Analysis/ModuleSummaryAnalysis.cpp:282
     for (const Instruction &I : BB) {
-      if (isa<DbgInfoIntrinsic>(I))
+      if (I.isDebugOrPseudoInst())
         continue;
----------------
Perhaps we should audit the use of DbgInfoIntrinsic to see if there're others that should be changed


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D109976/new/

https://reviews.llvm.org/D109976