[PATCH] D109907: [DSE] Use cached escape info for calls.
Florian Hahn via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Sep 17 08:51:29 PDT 2021
fhahn updated this revision to Diff 373239.
fhahn added a comment.
In D109907#3005187 <https://reviews.llvm.org/D109907#3005187>, @asbirlea wrote:
> Please document in detail that callCapturesBefore should only be called if the object does not escape before the call. Even if the public API is not available with this patch, it can be added in the future due to oversight if a comment does not explain this choice.
I added a comment to `callCaptures`, removed `callKnownNoCapture` and exposed `callCaptures` as public function instead. I also removed the redundant DT argument.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D109907/new/
https://reviews.llvm.org/D109907
Files:
llvm/include/llvm/Analysis/AliasAnalysis.h
llvm/lib/Analysis/AliasAnalysis.cpp
llvm/lib/Transforms/Scalar/DeadStoreElimination.cpp
llvm/test/Transforms/DeadStoreElimination/captures-before-call.ll
llvm/test/Transforms/DeadStoreElimination/captures-before-load.ll
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D109907.373239.patch
Type: text/x-patch
Size: 9643 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210917/d8a52cc4/attachment.bin>
More information about the llvm-commits
mailing list