foad added a comment. The logic looks good to me now. I wonder if we should have an overload of KnownBits::makeConstant that takes a uint64_t? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109883/new/ https://reviews.llvm.org/D109883