[llvm] cbaaede - [CodeGen] MachineInstr::getUsedDebugRegs() - Use const-ref iterator in for-range loop. NFCI.

Simon Pilgrim via llvm-commits llvm-commits at lists.llvm.org
Fri Sep 17 04:12:46 PDT 2021


Author: Simon Pilgrim
Date: 2021-09-17T12:11:54+01:00
New Revision: cbaaedea56fade69bf12164155734efece0f8931

URL: https://github.com/llvm/llvm-project/commit/cbaaedea56fade69bf12164155734efece0f8931
DIFF: https://github.com/llvm/llvm-project/commit/cbaaedea56fade69bf12164155734efece0f8931.diff

LOG: [CodeGen] MachineInstr::getUsedDebugRegs() - Use const-ref iterator in for-range loop. NFCI.

Avoid unnecessary copies, reported by MSVC static analyzer.

Added: 
    

Modified: 
    llvm/include/llvm/CodeGen/MachineInstr.h

Removed: 
    


################################################################################
diff  --git a/llvm/include/llvm/CodeGen/MachineInstr.h b/llvm/include/llvm/CodeGen/MachineInstr.h
index f76928c24194..ddace63b4218 100644
--- a/llvm/include/llvm/CodeGen/MachineInstr.h
+++ b/llvm/include/llvm/CodeGen/MachineInstr.h
@@ -517,7 +517,7 @@ class MachineInstr
   SmallSet<Register, 4> getUsedDebugRegs() const {
     assert(isDebugValue() && "not a DBG_VALUE*");
     SmallSet<Register, 4> UsedRegs;
-    for (auto MO : debug_operands())
+    for (const auto &MO : debug_operands())
       if (MO.isReg() && MO.getReg())
         UsedRegs.insert(MO.getReg());
     return UsedRegs;


        


More information about the llvm-commits mailing list