[llvm] e4b2f66 - [TableGen] Record::checkRecordAssertions() - Use const-ref iterator in for-range loop. NFCI.

[Simon Pilgrim via llvm-commits]

Author: Simon Pilgrim
Date: 2021-09-17T12:11:53+01:00
New Revision: e4b2f66d7f7e27e01ecf4da240f1c39387dd9ede

URL: https://github.com/llvm/llvm-project/commit/e4b2f66d7f7e27e01ecf4da240f1c39387dd9ede
DIFF: https://github.com/llvm/llvm-project/commit/e4b2f66d7f7e27e01ecf4da240f1c39387dd9ede.diff

LOG: [TableGen] Record::checkRecordAssertions() - Use const-ref iterator in for-range loop. NFCI.

Avoid unnecessary copies, reported by MSVC static analyzer.

Added: 
    

Modified: 
    llvm/lib/TableGen/Record.cpp

Removed: 
    


################################################################################
diff  --git a/llvm/lib/TableGen/Record.cpp b/llvm/lib/TableGen/Record.cpp
index 8663863d968f..aee8b853a0d9 100644
--- a/llvm/lib/TableGen/Record.cpp
+++ b/llvm/lib/TableGen/Record.cpp
@@ -2653,7 +2653,7 @@ void Record::checkRecordAssertions() {
   RecordResolver R(*this);
   R.setFinal(true);
 
-  for (auto Assertion : getAssertions()) {
+  for (const auto &Assertion : getAssertions()) {
     Init *Condition = Assertion.Condition->resolveReferences(R);
     Init *Message = Assertion.Message->resolveReferences(R);
     CheckAssert(Assertion.Loc, Condition, Message);