[PATCH] D105105: [DSE][NFC] Extend isOverwrite to take non zero initial offset

[Florian Hahn via Phabricator via llvm-commits]

fhahn added a comment.

It's hard to evaluate the impact of the change on its own. Is it strictly required for D90095 <https://reviews.llvm.org/D90095> or could if be a follow-up to D90095 <https://reviews.llvm.org/D90095> where we can show improvements on tests for this patch?



================
Comment at: llvm/lib/Transforms/Scalar/DeadStoreElimination.cpp:995
+    // offsets to see if the later store fully overwrites the earlier one.
     // If we hit a partial alias we may have a full overwrite
+    if (AAR == AliasResult::MustAlias ||
----------------
This comment needs updating, the if below now handles the must alias and partial alias case. The logic might be easier to follow & document if mustalias/partialalias logic would be kept separate, at the cost of minor code duplication.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D105105/new/

https://reviews.llvm.org/D105105