[PATCH] D109452: implement the --syms and using "symbol index and qualname" for --sym --symbol--description for llvm-objdump for xcoff

[James Henderson via Phabricator via llvm-commits]

jhenderson added inline comments.


================
Comment at: llvm/test/tools/llvm-objdump/XCOFF/symbol-table.test:2
+; Test the --syms option for xcoff object files. 
+; Test the --syms --symbol-description options for xcoff object file.
+; RUN: llc -mtriple powerpc-ibm-aix -mcpu=pwr4 -filetype=obj -o %t.o < %s
----------------
Sorry, should have said this before.


================
Comment at: llvm/test/tools/llvm-objdump/XCOFF/symbol-table.test:111
+; SYM-DES-NEXT: 000000ec l     O *COM*      00000004 (idx: 37) si[BS]
+
----------------
Nit, don't have a completely empty blank line like this here (do keep the single '\n' at the end of the last line with text to avoid the "no new line at end of file" note).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D109452/new/

https://reviews.llvm.org/D109452