[PATCH] D108772: [LSR] Make sure that Factor fits into Base type

[Quentin Colombet via Phabricator via llvm-commits]

qcolombet added inline comments.


================
Comment at: llvm/test/Transforms/LoopStrengthReduce/pr42770.ll:1
 ; Check that it doesn't crash
 ; REQUIRES: asserts
----------------
Could you check that we generate something sensible here as opposed to just no-crash?


================
Comment at: llvm/test/Transforms/LoopStrengthReduce/pr42770.ll:1
 ; Check that it doesn't crash
 ; REQUIRES: asserts
----------------
qcolombet wrote:
> Could you check that we generate something sensible here as opposed to just no-crash?
Could you set a more descriptive file name than a pr number?

E.g., incompatible IV type and add the PR number in the comment of the test.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D108772/new/

https://reviews.llvm.org/D108772