[PATCH] D109351: [NFC][AMDGPU] Reduce includes dependencies, part 2

Daniil Fukalov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Sep 16 15:42:45 PDT 2021


dfukalov added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/AMDGPUISelDAGToDAG.h:14-15
+
+#ifndef LLVM_LIB_TARGET_AMDGPU_AMDGPUISELDAGTODAG_H
+#define LLVM_LIB_TARGET_AMDGPU_AMDGPUISELDAGTODAG_H
+
----------------
arsenm wrote:
> What's the point of splitting this out? Nothing outside needs to access this
New "R600ISelDAGToDAG.cpp" uses `class AMDGPUDAGToDAGISel` declared below in the header.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D109351/new/

https://reviews.llvm.org/D109351



More information about the llvm-commits mailing list