[PATCH] D109397: [AttributeList] Change indexes in AttributeList::AttrIndex

[Nikita Popov via Phabricator via llvm-commits]

nikic added a reviewer: nikic.
nikic added a comment.

I'm not convinced that this change is worthwhile. After your recent cleanup, there's not a lot of places working directly with attribute indexes. Especially because we need to keep backwards-compatibility in multiple places, I don't think this change makes things clearer -- especially the fact that "attribute index" in the C API and in the C++ API will now have different meanings is concerning. I can't even say that the new indexes are less arbitrary than the old ones -- the only real advantage they have is that they're directly usable as array offsets.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D109397/new/

https://reviews.llvm.org/D109397