[PATCH] D109914: [Support] Attempt to fix deadlock in ThreadGroup
Mehdi AMINI via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Sep 16 14:35:22 PDT 2021
mehdi_amini added inline comments.
================
Comment at: llvm/lib/Support/Parallel.cpp:155
+TaskGroup::~TaskGroup() {
+ L.sync();
+ --TaskGroupInstances;
----------------
MaskRay wrote:
> L is a member of TaskGroup. Hasn't its destructor already run `sync`?
`~TaskGroup()` is invoked before destructing the individual members of the `TaskGroup` class.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D109914/new/
https://reviews.llvm.org/D109914
More information about the llvm-commits
mailing list