[PATCH] D107533: [lld-macho] Handle encoding personalities of same names but different kinds

Jez Ng via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Sep 16 12:57:28 PDT 2021


int3 added inline comments.


================
Comment at: lld/MachO/UnwindInfoSection.cpp:203
+        if (!defined->isExternal()) {
+          const auto &entries = in.got->getEntries();
+          auto it = localSymMap.find(defined);
----------------
why not use `SymbolTable::find()` instead?

> Right now, this just pick whatever comes first

There will only be one symbol of a given name in the global symbol table, so that issue is avoided too :)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D107533/new/

https://reviews.llvm.org/D107533



More information about the llvm-commits mailing list