[PATCH] D109893: [llvm-profgen] Use context-sensitive byte size cost for preinliner decisions by default

[Wenlei He via Phabricator via llvm-commits]

wenlei updated this revision to Diff 372991.
wenlei added a comment.

update test


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D109893/new/

https://reviews.llvm.org/D109893

Files:
  llvm/test/tools/llvm-profgen/cs-preinline-cost.test
  llvm/tools/llvm-profgen/CSPreInliner.cpp


Index: llvm/tools/llvm-profgen/CSPreInliner.cpp
===================================================================
--- llvm/tools/llvm-profgen/CSPreInliner.cpp
+++ llvm/tools/llvm-profgen/CSPreInliner.cpp
@@ -45,7 +45,7 @@
              "estimated global top-down inline decisions"));
 
 cl::opt<bool> UseContextCostForPreInliner(
-    "use-context-cost-for-preinliner", cl::Hidden, cl::init(false),
+    "use-context-cost-for-preinliner", cl::Hidden, cl::init(true),
     cl::desc("Use context-sensitive byte size cost for preinliner decisions"));
 
 static cl::opt<bool> SamplePreInlineReplay(
Index: llvm/test/tools/llvm-profgen/cs-preinline-cost.test
===================================================================
--- llvm/test/tools/llvm-profgen/cs-preinline-cost.test
+++ llvm/test/tools/llvm-profgen/cs-preinline-cost.test
@@ -1,6 +1,6 @@
 ; REQUIRES: asserts
 ; Test default using size of profile as a proxy
-; RUN: llvm-profgen --format=text --perfscript=%S/Inputs/cs-preinline-cost.perfscript --binary=%S/Inputs/cs-preinline-cost.perfbin --csspgo-preinliner --debug-only=cs-preinliner --output=/dev/null 2>&1 | FileCheck %s --check-prefix=CHECK-DEFAULT
+; RUN: llvm-profgen --format=text --perfscript=%S/Inputs/cs-preinline-cost.perfscript --binary=%S/Inputs/cs-preinline-cost.perfbin --csspgo-preinliner --debug-only=cs-preinliner --use-context-cost-for-preinliner=0 --output=/dev/null 2>&1 | FileCheck %s --check-prefix=CHECK-DEFAULT
 
 ; Test use-context-cost-for-preinliner using inlinee's byte size as context-sensitive inline cost
 ; RUN: llvm-profgen --format=text --perfscript=%S/Inputs/cs-preinline-cost.perfscript --binary=%S/Inputs/cs-preinline-cost.perfbin --csspgo-preinliner --debug-only=cs-preinliner --use-context-cost-for-preinliner --output=/dev/null 2>&1 | FileCheck %s --check-prefix=CHECK-CSCOST


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D109893.372991.patch
Type: text/x-patch
Size: 1833 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210916/734f8b9d/attachment.bin>