[PATCH] D109855: [LoopPredication] Report changes correctly when attempting loop exit predication

Philip Reames via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Sep 16 09:34:33 PDT 2021


reames accepted this revision.
reames added a comment.
This revision is now accepted and ready to land.

LGTM.

Your code is correct and fixes a real potential issue, but your test may not be the best one.  From what I can tell, the changes being missed were strictly mutations/moves of instructions, not manipulations of the CFG.  As a result, the CFG analysis you're testing being invalidated could actually be preserved with a bit of extra work.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D109855/new/

https://reviews.llvm.org/D109855



More information about the llvm-commits mailing list