[PATCH] D109868: [MemProf] Don't instrument stack accesses unless requested

[Snehasish Kumar via Phabricator via llvm-commits]

snehasish added inline comments.


================
Comment at: llvm/lib/Transforms/Instrumentation/MemProfiler.cpp:125
 
+static cl::opt<bool> ClStack("memprof-stack",
+                             cl::desc("Instrument scalar stack variables"),
----------------
Perhaps call this `memprof-instrument-stack`, the usage will be clear from the name itself?


Also I think moving this to L110 is better since the comment at L111 seems to indicate all flags following it are debug flags.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D109868/new/

https://reviews.llvm.org/D109868