[PATCH] D108607: [RISCV] Optimize (add (mul x, c0), c1)

Craig Topper via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Sep 16 08:30:04 PDT 2021


craig.topper added inline comments.


================
Comment at: llvm/lib/Target/RISCV/RISCVISelLowering.cpp:6191
+  case ISD::ADD: {
+    SDValue NA = transformAddImmMulImm(N, DAG, Subtarget.getXLen());
+    if (NA)
----------------
Please put this call in performADDCombine. The idea was that all ADD specific things should be in one place. This switch is getting pretty crazy.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D108607/new/

https://reviews.llvm.org/D108607



More information about the llvm-commits mailing list