[PATCH] D109803: Extract LC_CODE_SIGNATURE related implementation out of LLD
Jez Ng via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Sep 16 08:10:20 PDT 2021
int3 added inline comments.
================
Comment at: lld/MachO/SyntheticSections.cpp:1155-1157
+ object::CodeSignatureSection sectionBuilder = object::CodeSignatureSection(
+ fileOff, config->outputFile, config->outputType, textSeg->fileOff,
+ textSeg->fileSize);
----------------
can we construct this once in `CodeSignatureSection::finalize()`? (so CodeSignatureSection would have a `std::unique_ptr<object::CodeSignatureSection>` member that can be reused in `writeHashes`)
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D109803/new/
https://reviews.llvm.org/D109803
More information about the llvm-commits
mailing list