[PATCH] D103770: Injection of kernel features into the LLVM IR during the OpenMP transform stage

[Johannes Doerfert via Phabricator via llvm-commits]

jdoerfert added a comment.

In D103770#2881332 <https://reviews.llvm.org/D103770#2881332>, @JonChesterfield wrote:

> Good feature, but using an array for this looks likely to be error prone.  Do we need to iterate over it somewhere? Order of fields seems likely to end up repeated in a few places.
>
> I think I'd prefer N distinct scalars with names like multiply_kernel.KernelFeature.MaxLoopDepth. Might make the test cases more legible too.

When we read out the values it is much more reasonable to do so in one go. More features are on the way, reading them out one by one will cost too much time to make it practical.
With the usage and printing in the runtime D109882 <https://reviews.llvm.org/D109882> this should make more sense.

That said, we should even merge other globals into a single one, incl. exec_mode.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D103770/new/

https://reviews.llvm.org/D103770