[PATCH] D108916: [RISCV] Optimize (add (shl x, c0), (shl y, c1)) with SH*ADD

Ben Shi via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Sep 16 07:11:01 PDT 2021


benshi001 added a comment.

In D108916#3003531 <https://reviews.llvm.org/D108916#3003531>, @luismarques wrote:

> I had started reviewing this before D109729 <https://reviews.llvm.org/D109729>, now I'm very confused about the point of the two patches...

The reason I created https://reviews.llvm.org/D109729 is that current patch has been pending for weeks and I thought you disagree with it.

So I created https://reviews.llvm.org/D109729, which initial version is the same optimization implemented in TD rules. However TD rules were in bad form so I changed it to DAG2GAG.

However I think both patches are OK. If current one can be accepted, then I will close https://reviews.llvm.org/D109729.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D108916/new/

https://reviews.llvm.org/D108916



More information about the llvm-commits mailing list