[PATCH] D109834: [lldb/win] Improve check-lldb-shell with LLVM_ENABLE_DIA_SDK=NO

Nico Weber via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Sep 16 04:37:18 PDT 2021


thakis added a comment.

In D109834#3003250 <https://reviews.llvm.org/D109834#3003250>, @labath wrote:

> I fear this is going to be an endless whack-a-mole. There's no way every contributor will remember to (correctly) add this feature.

I think that's ok. 10/250 shell tests need it and there isn't a ton of churn in these tests, so folks on windows can update it as needed.

(If you have a better idea, I'm all ears of course.)


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D109834/new/

https://reviews.llvm.org/D109834



More information about the llvm-commits mailing list