[PATCH] D109577: [LNT] Fixed incorrect orders behavior in case of miss formatted llvm_project_revision

Thomas Preud'homme via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Sep 16 02:53:26 PDT 2021


thopre added a comment.

In D109577#3003389 <https://reviews.llvm.org/D109577#3003389>, @kpdev42 wrote:

> This code wont change previous behavior for versions which contains digits. 
> In this commit it is intended to prevent a situation when DB became silently inconsistent if llvm_project_revision does not contain any digit.
> e.g: "alpha", "beta", "private", "main", "test", etc

My point is that llvm_project_revision should only contain digits and dots. We should give an error if that's not the case rather than trying to avoid DB inconsistencies.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D109577/new/

https://reviews.llvm.org/D109577



More information about the llvm-commits mailing list