[PATCH] D108416: [WORK IN PROGRESS][llvm-libgcc] initial commit

[Daniel Kiss via Phabricator via llvm-commits]

danielkiss added a comment.

`gcc_s-armhf.ver` version script (copy/symlink of armv7) is needed too.



================
Comment at: llvm/libgcc/FindCompilerRT.cmake:1
+include(FindPackageHandleStandardArgs)
+
----------------
CMake complained about the missing reference:
`+include(CheckLibraryExists)` 


================
Comment at: llvm/libgcc/FindCompilerRT.cmake:48-49
+
+    check_library_exists("${LLVM_LIBGCC_PATH_TO_RTLIB}" emutls_key_destructor
+      LLVM_LIBGCC_HAS_EXTERNAL_RTLIB)
+    if (NOT LLVM_LIBGCC_HAS_EXTERNAL_RTLIB)
----------------
maybe just say:
`check_library_exists("libclang_rt.builtins-${LLVM_LIBGCC_TARGET}.a" emutls_key_destructor "${LLVM_LIBGCC_COMPILER_RT_DIR}")`


================
Comment at: llvm/libgcc/docs/LLVMLibgcc.rst:168
+  $ LLVM_LIBGCC_SYSROOT=/tmp/llvm-libgcc-experiment
+  $ cmake -GNinja ../../llvm-libgcc                             \
+      -DCMAKE_BUILD_TYPE=Release                                \
----------------
typo


================
Comment at: llvm/libgcc/lib/CMakeLists.txt:16-17
+  -Wl,--version-script,${LLVM_LIBGCC_VERSION_SCRIPT_PATH}
+  -Wl,${LLVM_LIBGCC_SYSROOT}/lib${LLVMLIB_DIR_SUFFIX}/${LLVM_LIBGCC_COMPILER_RT}
+  -Wl,${LLVM_LIBGCC_SYSROOT}/lib${LLVMLIB_DIR_SUFFIX}/${LLVM_LIBGCC_UNWIND_STATIC}
+  -Wl,--no-whole-archive
----------------
This worked for me, other wise the path was wrong:
```-  -Wl,${LLVM_LIBGCC_SYSROOT}/lib${LLVMLIB_DIR_SUFFIX}/${LLVM_LIBGCC_COMPILER_RT}
-  -Wl,${LLVM_LIBGCC_SYSROOT}/lib${LLVMLIB_DIR_SUFFIX}/${LLVM_LIBGCC_UNWIND_STATIC}
+  -Wl,${LLVM_LIBGCC_COMPILER_RT}
+  -Wl,${LLVM_LIBGCC_UNWIND_STATIC}```


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D108416/new/

https://reviews.llvm.org/D108416