[PATCH] D109868: [MemProf] Don't instrument stack accesses unless requested

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added inline comments.


================
Comment at: llvm/lib/Transforms/Instrumentation/MemProfiler.cpp:459
+    if (Access.IsWrite)
+      NumSkippedStackWrites++;
+    else
----------------
the coding standard prefer pre-increment.


================
Comment at: llvm/test/Instrumentation/HeapProfiler/stack.ll:4
+; RUN: opt < %s -memprof -memprof-module -S | FileCheck --check-prefixes=CHECK %s
+; RUN: opt < %s -memprof -memprof-module -memprof-stack -S | FileCheck --check-prefixes=CHECK,STACK %s
+
----------------
Legacy PM tests are being deleted. For new tests, just avoid them.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D109868/new/

https://reviews.llvm.org/D109868