[PATCH] D109803: Extract LC_CODE_SIGNATURE related implementation out of LLD

Vy Nguyen via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Sep 15 19:54:32 PDT 2021


oontvoo accepted this revision as: oontvoo.
oontvoo added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: llvm/lib/Object/CodeSignatureSection.cpp:27
+
+static_assert((CodeSignatureSection::BlobHeadersSize % 8) == 0, "");
+static_assert((CodeSignatureSection::FixedHeadersSize % 8) == 0, "");
----------------
oontvoo wrote:
> not needed - unless you're going to add some text here?
Oops, sorry about this suggestion - I forgot LLVM is still on C++14. 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D109803/new/

https://reviews.llvm.org/D109803



More information about the llvm-commits mailing list