[PATCH] D109823: [GlobalOpt] Do not shrink global to bool for an unfavorable AS

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added inline comments.


================
Comment at: llvm/test/Transforms/GlobalOpt/shrink-global-to-bool.ll:2
+; NOTE: Assertions have been autogenerated by utils/update_test_checks.py
+; RUN: opt -passes=globalopt --mtriple=x86_64-unknown-linux-gnu < %s -S | FileCheck %s
+; RUN: opt -passes=globalopt --mtriple=amdgcn-amd-amdhsa < %s -S | FileCheck %s
----------------
If they're going to have the same output, there's no point in the second run line. The cpu run line was only useful as a reference to make sure the transform happened otherwise


================
Comment at: llvm/test/Transforms/GlobalOpt/shrink-global-to-bool.ll:4
+; RUN: opt -passes=globalopt --mtriple=amdgcn-amd-amdhsa < %s -S | FileCheck %s
+; REQUIRES: amdgpu-registered-target
+
----------------
Would also need x86 check


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D109823/new/

https://reviews.llvm.org/D109823