[PATCH] D106995: [IROutliner] Allowing PHINodes in Exit Blocks

[Jessica Paquette via Phabricator via llvm-commits]

paquette added inline comments.


================
Comment at: llvm/lib/Transforms/IPO/IROutliner.cpp:1430
+/// \p PN.
+/// \param AdjustArgNo - A flag to use the extracted function call of \p Region
+/// rather than the overall function's call.
----------------
update comment to reflect variable name?


================
Comment at: llvm/lib/Transforms/IPO/IROutliner.cpp:2226
 
+/// For the \p OutputCanon number passed in find the value represented by this,
+/// canonical number. If it is from a PHINode, we pick one the first incoming
----------------



================
Comment at: llvm/lib/Transforms/IPO/IROutliner.cpp:2227
+/// For the \p OutputCanon number passed in find the value represented by this,
+/// canonical number. If it is from a PHINode, we pick one the first incoming
+/// value and return that.
----------------
"one the first incoming value" doesn't parse for me


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D106995/new/

https://reviews.llvm.org/D106995