[PATCH] D109840: Add MachO signature verification test

[Jez Ng via Phabricator via llvm-commits]

int3 accepted this revision.
int3 added a comment.
This revision is now accepted and ready to land.

lgtm



================
Comment at: lld/test/MachO/adhoc-codesign-hash.s:16-33
+# ARM64-MACOS: - cmd:             LC_CODE_SIGNATURE
+# ARM64-MACOS-NEXT: cmdsize:         16
+# ARM64-MACOS-NEXT: dataoff:         16400
+# ARM64-MACOS-NEXT: datasize:        304
+
+# ARM64-IOS: - cmd:             LC_CODE_SIGNATURE
+# ARM64-IOS-NEXT: cmdsize:         16
----------------
nuriamari wrote:
> int3 wrote:
> > oontvoo wrote:
> > > Perhaps consider using variables here to avoid duplication? (also easier for future updates?)
> > > 
> > > (suggested diff is in-complete -- only included one eg)
> > nit: try to vertically align where possible (same for lines below)
> I haven't been able to get what you are suggesting working. Are `FileCheck` capture variables usable within a run command? 
What @oontvoo left out was how to define variables for FileCheck :) you'll want something like `-D#DATAOFF=16400` here for the substitution to work. Then you can reference it via `[[#DATAOFF]]`. (The `#` indicates that the value is an integer. It only matters if you want to do arithmetic on the values, which doesn't apply in this case, but it's nice to use `#` anyway for clarity.)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D109840/new/

https://reviews.llvm.org/D109840