[PATCH] D109351: [NFC][AMDGPU] Reduce includes dependencies, part 2

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/AMDGPUISelDAGToDAG.h:14-15
+
+#ifndef LLVM_LIB_TARGET_AMDGPU_AMDGPUISELDAGTODAG_H
+#define LLVM_LIB_TARGET_AMDGPU_AMDGPUISELDAGTODAG_H
+
----------------
What's the point of splitting this out? Nothing outside needs to access this


================
Comment at: llvm/lib/Target/AMDGPU/AMDGPUISelDAGToDAG.h:26
+
+bool isNullConstantOrUndef(SDValue V) {
+  if (V.isUndef())
----------------
Bot is warning you to add inlines


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D109351/new/

https://reviews.llvm.org/D109351