[PATCH] D109837: cmake: Deprecate config.guess
Fangrui Song via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Sep 15 13:29:45 PDT 2021
MaskRay added a comment.
In D109837#3002538 <https://reviews.llvm.org/D109837#3002538>, @tstellar wrote:
> In D109837#3002372 <https://reviews.llvm.org/D109837#3002372>, @MaskRay wrote:
>
>> I have thought again: we don't even need `LLVM_USE_CONFIG_GUESS`. The warning can just ask the user to run `sh llvm/cmake/config.guess` manually and re-run cmake with -DLLVM_HOST_TRIPLE=, with a caution that the config.guess value may not be correct.
>
> I like this approach, but what if we took it step further and asked them to download config.guess from https://raw.githubusercontent.com/gcc-mirror/gcc/master/config.guess so that we could remove it from the llvm tree entirely?
Sounds good!
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D109837/new/
https://reviews.llvm.org/D109837
More information about the llvm-commits
mailing list