[PATCH] D109837: cmake: Deprecate config.guess

[Tom Stellard via Phabricator via llvm-commits]

tstellar marked 4 inline comments as done.
tstellar added inline comments.


================
Comment at: llvm/cmake/modules/GetHostTriple.cmake:70
+        message(FATAL_ERROR "Unable to determine host triple.  Please file a bug.  "
+                             "You may work around this for now configuring with "
+                             "-DLLVM_USE_CONFIG_GUESS=ON, however, this option "
----------------
MaskRay wrote:
> Mention `-DLLVM_HOST_TRIPLE=`?
> 
> Seems that `LLVM_HOST_TRIPLE` is used to initialize `LLVM_DEFAULT_TARGET_TRIPLE` (`llvm/CMakeLists.txt`), so setting `LLVM_HOST_TRIPLE` is sufficient even in the absence of config.guess
Ok, I think this means I need to change this from a FATAL_ERROR to a WARNING, since get_host_triple gets called even if LLVM_HOST_TRIPLE is set.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D109837/new/

https://reviews.llvm.org/D109837