[PATCH] D109840: Add MachO signature verification test

[Vy Nguyen via Phabricator via llvm-commits]

oontvoo added inline comments.


================
Comment at: lld/test/MachO/Inputs/code-signature-check.py:1
+#! /usr/bin/env python3
+
----------------
Any chance this could be omitted for portability?  (since you've already invoked the script with `%python` below)?
(also is python3 a must?) 


================
Comment at: lld/test/MachO/adhoc-codesign-hash.s:16-33
+# ARM64-MACOS: - cmd:             LC_CODE_SIGNATURE
+# ARM64-MACOS-NEXT: cmdsize:         16
+# ARM64-MACOS-NEXT: dataoff:         16400
+# ARM64-MACOS-NEXT: datasize:        304
+
+# ARM64-IOS: - cmd:             LC_CODE_SIGNATURE
+# ARM64-IOS-NEXT: cmdsize:         16
----------------
Perhaps consider using variables here to avoid duplication? (also easier for future updates?)

(suggested diff is in-complete -- only included one eg)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D109840/new/

https://reviews.llvm.org/D109840