[PATCH] D109837: cmake: Deprecate config.guess

Wed Sep 15 10:02:18 PDT 2021

MaskRay added inline comments.

================
Comment at: llvm/CMakeLists.txt:479
+option(LLVM_USE_CONFIG_GUESS
+   "(deprecated) Use config.guess to determine host architecture.  This option will be removed in the future." OFF)
+
----------------
Remove trailing `.` for the help message to be consistent with other options.

================
Comment at: llvm/cmake/modules/GetHostTriple.cmake:70
+        message(FATAL_ERROR "Unable to determine host triple.  Please file a bug.  "
+                             "You may work around this for now configuring with "
+                             "-DLLVM_USE_CONFIG_GUESS=ON, however, this option "
----------------
Mention `-DLLVM_HOST_TRIPLE=`?

Seems that `LLVM_HOST_TRIPLE` is used to initialize `LLVM_DEFAULT_TARGET_TRIPLE` (`llvm/CMakeLists.txt`), so setting `LLVM_HOST_TRIPLE` is sufficient even in the absence of config.guess

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D109837/new/

https://reviews.llvm.org/D109837