[PATCH] D109803: Extract LC_CODE_SIGNATURE related implementation out of LLD

Wed Sep 15 10:01:39 PDT 2021

thakis added a comment.

In D109803#3001885 <https://reviews.llvm.org/D109803#3001885>, @nuriamari wrote:

> In D109803#3001863 <https://reviews.llvm.org/D109803#3001863>, @thakis wrote:
>
>> Move itself looks fine, but why is there a new lld test in here? This should be behavior-preserving, so I wouldn't expect test updates.
>>
>> If you want to add a new test to lld independently from this change (?), I'd put that in a separate patch.
>
> The new test is to ensure no behavior is broken. The existing code signature related test <https://github.com/llvm/llvm-project/blob/main/lld/test/MachO/adhoc-codesign.s> does not test that the hash was performed properly, just that the load command is included. This test is to make sure the move doesn't break the signature generation.

Can we land that in its own patch? :)

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D109803/new/

https://reviews.llvm.org/D109803