[PATCH] D109823: [GlobalOpt] Do not shrink global to bool for an unfavorable AS

Wed Sep 15 09:43:06 PDT 2021

tra added a comment.

The patch looks reasonable, but I have a question about the test.

================
Comment at: llvm/test/Transforms/GlobalOpt/shrink-global-to-bool.ll:33-41
+; CHECK-LABEL: @test_lds_var(
+; CHECK:    store i32 10, i32 addrspace(3)* @lvar, align 4
+; CHECK:    [[LD:%.*]] = load i32, i32 addrspace(3)* @lvar, align 4
+; CHECK:    store volatile i32 [[LD]], i32* undef, align 4
+;
+; AMDGCN-LABEL: @test_lds_var(
+; AMDGCN:    store i32 10, i32 addrspace(3)* @lvar, align 4
----------------
I'm confused. I see no differences between AMDGCN and CHECK anywhere in the test file.  AFAICT, the test would work if I were to use CHECK in the test with `--mtriple=amdgcn-amd-amdhsa`. If both CHECK and AMDGCN are identical, why do we need two different check patterns?

Did I miss something?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D109823/new/

https://reviews.llvm.org/D109823